Announced deprecated APIs still in use

[augustocravosilva]

Github has announced some deprecations here
https://developer.github.com/changes/2019-11-05-deprecated-passwords-and-authorizations-api/#deprecating-and-adding-endpoints-for-the-oauth-authorizations-and-oauth-applications-apis

But octokit.rb seems to still be using the deprecated methods.
For example,

octokit.rb/lib/octokit/client/authorizations.rb

Lines 154 to 161 in a0ecb99

	def check_application_authorization(token, options = {})
	opts = options.dup
	key = opts.delete(:client_id) || client_id
	secret = opts.delete(:client_secret) || client_secret
	as_app(key, secret) do |app_client|
	app_client.get "applications/#{client_id}/tokens/#{token}", opts
	end

Should be replaced by POST /applications/:client_id/token

[donalod]

Howdy, got another email about this today from Github and as far as I can tell, am not using any explicit queries, so it's just the underlying code above? https://developer.github.com/changes/2020-02-10-deprecating-auth-through-query-param/

[tarebyte]

No you’re right it’s the underlying code, I think we forgot about the new endpoints before shipping the last release.

I’ll take a look and see which ones need updating.

[MGudgin]

@tarebyte I've submitted a PR to update octokit.net.

[tarebyte]

I appreciate the effort ✨ unfortunately I don't know C# very well to review it 😅

I'll leave that up to the maintainers of the repo. I only support the Ruby version.

[tarebyte]

Closed by #1203, will report back when we cut a release.