Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: redirect option not passed through #611

Closed
1 task done
wolfy1339 opened this issue Jul 9, 2023 · 3 comments · Fixed by #612
Closed
1 task done

[BUG]: redirect option not passed through #611

wolfy1339 opened this issue Jul 9, 2023 · 3 comments · Fixed by #612
Labels
released Type: Bug Something isn't working as documented

Comments

@wolfy1339
Copy link
Member

What happened?

The redirect option is still defined in the types as an option that can be passed, however it isn't getting passed along

Versions

@octokit/request v8

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@wolfy1339 wolfy1339 added the Type: Bug Something isn't working as documented label Jul 9, 2023
@github-project-automation github-project-automation bot moved this to 🆕 Triage in 🧰 Octokit Active Jul 9, 2023
@wolfy1339
Copy link
Member Author

Is it an error that the types were left in, or is it an error that it isn't passed through

@gr2m
Copy link
Contributor

gr2m commented Jul 9, 2023

redirect is a valid fetch option:
https://developer.mozilla.org/en-US/docs/Web/API/fetch#redirect

I'd pass it through like signal. There are a few others but I'd wait and see to learn about people's use cases for them. I think most are relevant to browsers only.

@github-project-automation github-project-automation bot moved this from 🆕 Triage to ✅ Done in 🧰 Octokit Active Jul 9, 2023
@github-actions
Copy link

github-actions bot commented Jul 9, 2023

🎉 This issue has been resolved in version 8.0.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Type: Bug Something isn't working as documented
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants