Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: export type only RestEndpointMethodTypes #299

Merged
merged 3 commits into from
May 20, 2023
Merged

Conversation

antfu
Copy link
Contributor

@antfu antfu commented May 20, 2023

Resolves #298


Behavior

Before the change?

Reexport of type RestEndpointMethodTypes appears in the js dist.

After the change?

Only re-export it as type.

Other information

This also breaks Vite when trying to import octokit in the client side.


Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes (Please add the Type: Breaking change label)
  • No

If Yes, what's the impact:

  • N/A

Pull request type

Please add the corresponding label for change this PR introduces:

  • Bugfix: Type: Bug
  • Feature/model/API additions: Type: Feature
  • Updates to docs or samples: Type: Documentation
  • Dependencies/code cleanup: Type: Maintenance

src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
@wolfy1339 wolfy1339 added the Type: Bug Something isn't working as documented label May 20, 2023
@wolfy1339 wolfy1339 merged commit 11f8e63 into octokit:main May 20, 2023
@github-actions
Copy link
Contributor

🎉 This PR is included in version 19.0.10 🎉

The release is available on:

Your semantic-release bot 📦🚀

@antfu antfu deleted the patch-1 branch May 20, 2023 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Type: Bug Something isn't working as documented
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

CDN Bug
2 participants