Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add redirect option in RequestRequestOptions #630

Merged
merged 1 commit into from
Apr 9, 2024
Merged

feat: add redirect option in RequestRequestOptions #630

merged 1 commit into from
Apr 9, 2024

Conversation

wolfy1339
Copy link
Member

Before the change?

  • The redirect option was removed from @octokit/request v8

After the change?

  • Adds the redirect option, and moves it to RequestRequestOptions

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@wolfy1339 wolfy1339 added the Type: Feature New feature or request label Apr 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 9, 2024

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@wolfy1339 wolfy1339 mentioned this pull request Apr 9, 2024
Merged
4 tasks
gr2m
gr2m approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@wolfy1339 wolfy1339 merged commit 9c58158 into main Apr 9, 2024
7 checks passed
@wolfy1339 wolfy1339 deleted the add-redirect branch April 9, 2024 17:09
@octokitbot
Copy link
Collaborator

🎉 This PR is included in version 13.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

This was referenced Jul 16, 2024
Open
Open
Open
Open
Open
Open
Open
@WontonSam WontonSam mentioned this pull request Jul 20, 2024
Open
@snyk-io snyk-io bot mentioned this pull request Jul 22, 2024
Open
@WontonSam WontonSam mentioned this pull request Jul 25, 2024
Open
This was referenced Sep 16, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
@WontonSam WontonSam mentioned this pull request Sep 23, 2024
Open
@ebiz-markusrissmann ebiz-markusrissmann mentioned this pull request Oct 4, 2024
Open
This was referenced Oct 15, 2024
Open
Open
Open
@WontonSam WontonSam mentioned this pull request Oct 30, 2024
Open
@WontonSam WontonSam mentioned this pull request Nov 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gr2m gr2m gr2m approved these changes

Assignees
No one assigned
Labels
released Type: Feature New feature or request
Projects
🧰 Octokit Active
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wolfy1339 @octokitbot @gr2m