fix(typescript): Fix errors from linters and an update for signatures #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gr2m
reviewed
Jan 27, 2019
Co-Authored-By: wolfy1339 <4595477+wolfy1339@users.noreply.github.com>
gr2m
reviewed
Jan 27, 2019
scripts/generate-types.js
Outdated
| @@ -24,7 +24,8 @@ webhooks.forEach(({ name, actions, examples }) => { | |||
| ...actions.map(action => `'${name}.${action}'`) | |||
| ].join(' | ') | |||
| signatures.push(` | |||
| public on (event: ${events}, callback: (event: Webhooks.WebhookEvent<${typeName}>) => void): void | |||
| public on (event: ${events}, callback: (event: Webhooks.WebhookEvent<Webhooks.${typeName}>) => void): void | |||
| public on (event: ${events}, callback: (event: Webhooks.WebhookEvent<Webhooks.${typeName}>) => Promise<void>): void | |||
There was a problem hiding this comment.
I wonder, can you combine the two lines above?
public on (event: ${events}, callback: (event: Webhooks.WebhookEvent<Webhooks.${typeName}>) => void | Promise<void>): voidThere was a problem hiding this comment.
I'm not sure if It could work, I'll go test
The option argument is not required in the Webhooks class constructor. A `declare` modifier is needed for top-level declarations in a `.d.ts` file (TS1046)
|
@gr2m This is ready |
|
🎉 This PR is included in version 5.3.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can't use ESModule and CommonJS exports in the same file (you could theoretically, but it's bad practice), so we have to move the definitions into the namespace.
This does not affect the way to import the types, you can still do this:
In the
Optionstype, replace theTparameter withanysince it was not defined.