Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installation_repositories event types wrong #59

Closed
wolfy1339 opened this issue Jan 31, 2019 · 5 comments · Fixed by #60
Closed

installation_repositories event types wrong #59

wolfy1339 opened this issue Jan 31, 2019 · 5 comments · Fixed by #60

Comments

@wolfy1339
Copy link
Member

The types for the event installation_repositories are wrong and invalid, thus they don't work.

This is how they should look like

type WebhookPayloadInstallationRepositories = {
    action: string;
    installation: WebhookPayloadInstallationRepositoriesInstallation;
    repository_selection: string;
    repositories_added: Array<any>;
    repositories_removed: Array<
      WebhookPayloadInstallationRepositoriesRepositoriesRemovedItem
    >;
    sender: WebhookPayloadInstallationRepositoriesSender;
  };
@wolfy1339
Copy link
Member Author

This is probably an issue in @octokit/webhooks-definition, I have double checked the docs and they're correct.

@gr2m
Copy link
Contributor

gr2m commented Feb 16, 2019

@wolfy1339 any luck?

@wolfy1339
Copy link
Member Author

This problem lies somewhere else then @octokit/webhooks-definition, everything looks proper for that event in that file.

This issue is more likely with the type generation software, ping @gimenete

@gimenete
Copy link
Contributor

gimenete commented Feb 18, 2019

I've made a PR that fixes this. It was a problem with naming collision. The definition was not wrong. It was just a merged type (using unions) of two cases with the same name. So it was right and valid, but too broad. The PR generates two different types instead of one.

@gr2m gr2m closed this as completed in #60 Feb 18, 2019
@octokitbot
Copy link
Collaborator

🎉 This issue has been resolved in version 5.3.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants