Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for deployment_review event #816

Merged
merged 7 commits into from
Aug 10, 2023
Merged

Conversation

wolfy1339
Copy link
Member

Resolves #555


Behavior

Before the change?

  • The deployment_review event was not a supported event

After the change?

  • Adds definitions for the deplyment_review event

Other information

  • Since this event is completely undocumented, one has to infer the types from the other schemas and from user gathered payloads

Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes (Please add the Type: Breaking change label)
  • No

If Yes, what's the impact:

  • N/A

Pull request type

Please add the corresponding label for change this PR introduces:

  • Feature/model/API additions: Type: Feature

@wolfy1339 wolfy1339 added the Type: Feature New feature or request label Jul 13, 2023
@JamieMagee
Copy link

Event documentation is available here

@wolfy1339 wolfy1339 marked this pull request as ready for review August 10, 2023 00:56
@wolfy1339
Copy link
Member Author

This is now ready to go 🚀

@wolfy1339 wolfy1339 merged commit 4e36ca2 into main Aug 10, 2023
8 checks passed
@wolfy1339 wolfy1339 deleted the deployment-review branch August 10, 2023 17:15
@octokitbot
Copy link
Collaborator

🎉 This PR is included in version 7.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Type: Feature New feature or request
Projects
Status: 🏗 In progress
Development

Successfully merging this pull request may close these issues.

Add support for deployment_review event
3 participants