Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "cancelled" as possible conclusion of a completed workflow step #892

Merged
merged 2 commits into from
Feb 3, 2024

Conversation

eduramirezh
Copy link
Contributor

Resolves #891


Before the change?

  • Workflow steps with status "completed" CAN'T have a "cancelled" conclusion.

After the change?

  • Workflow steps with status "completed" CAN have a "cancelled" conclusion.

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

  • Yes
  • No

Copy link
Contributor

github-actions bot commented Feb 1, 2024

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@eduramirezh
Copy link
Contributor Author

When I run npm run build:typesI get:

> @octokit/webhooks-definitions@0.0.0-development build:types
> node --no-warnings=ExperimentalWarning --loader ts-node/esm bin/octokit-types.mts

node:internal/process/promises:289
            triggerUncaughtException(err, true /* fromPromise */);
            ^

[Error: ENOENT: no such file or directory, open './payload-schemas/schema.json'] {
  errno: -2,
  code: 'ENOENT',
  syscall: 'open',
  path: './payload-schemas/schema.json'
}

Node.js v20.11.0

How should I proceed @wolfy1339 ?

@wolfy1339
Copy link
Member

You have to generate the schema first using the npm run build:schema and then you can generate the types

@wolfy1339 wolfy1339 merged commit 6df0bc4 into octokit:main Feb 3, 2024
7 checks passed
@octokitbot
Copy link
Collaborator

🎉 This PR is included in version 7.3.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@eduramirezh
Copy link
Contributor Author

that was quick 😮 thank you @wolfy1339!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG]: completed workflow steps should have "cancelled" as possible conclusion
3 participants