-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable question retries on single questions #671
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #671 +/- ##
==========================================
- Coverage 94.55% 94.50% -0.06%
==========================================
Files 83 83
Lines 3546 3547 +1
==========================================
- Hits 3353 3352 -1
- Misses 193 195 +2 ☔ View full report in Codecov by Sentry. |
ffeb271
to
a56cc3c
Compare
a56cc3c
to
9092646
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of notes, but this is great overall - a performance boost, 150 lines code reduction, an extra feature and a simplification in logic flow. Thanks! :)
skipci
Summary
This release adds to the question retry capability already available on concurrent questions by allowing retries of single questions.
Contents (#671)
Enhancements
Child.ask
Child.ask
PYTHONUNBUFFERED
warningRefactoring
Child.ask_multiple
intoChild.ask