pull: relay along errors encountered #737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #734. Capture errors after parallelized pulls. Also avoid shadowing errors on result waiting. The changed code was legacy of an oversight after the old days in which we didn't send back exit codes to the outside world. After exit codes were added to drive, the pull code was never touched. Even still though, we had logging for errors and users could see their errors. Exhibits: * Unsuccessful pull ```shell drive pull --export pdf,rtf t1; echo $? Resolving... $ drive pull --export pdf,rtf t1; echo $? Resolving... M /test-docs/t1 Modification count 1 yroceed with the changes? [Y/n]: – /test-docs/t1 err: download: failed for url "". StatusCode: 400 download: failed for url "". StatusCode: 400 255 ``` * Successful pull ```shell $ drive pull --export pdf,rtf t1; echo $? Resolving... M /test-docs/t1 Modification count 1 Proceed with the changes? [Y/n]:y Exported '/Users/emmanuelodeke/emm.odeke@gmail.com/test-docs/t1' to '/Users/emmanuelodeke/emm.odeke@gmail.com/test-docs/t1_exports/t1.rtf' Exported '/Users/emmanuelodeke/emm.odeke@gmail.com/test-docs/t1' to '/Users/emmanuelodeke/emm.odeke@gmail.com/test-docs/t1_exports/t1.pdf' 0 ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #734.
Capture errors after parallelized pulls.
Also avoid shadowing errors on result waiting.
The changed code was legacy of an oversight after the old days
in which we didn't send back exit codes to the outside world.
After exit codes were added to drive, the pull code was never touched.
Even still though, we had logging for errors and users could see their
errors.
Exhibits: