Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The recordset's repr() changes and is misleading #1

Closed
yajo opened this issue Oct 21, 2020 · 7 comments
Closed

The recordset's repr() changes and is misleading #1

yajo opened this issue Oct 21, 2020 · 7 comments

Comments

@yajo
Copy link

yajo commented Oct 21, 2020

Look at how self looks in VSCode without the plugin:

2020-10-21_10-02

With it:

2020-10-21_10-06

As said in Tecnativa/doodba#333 (comment), the fact that self becomes [1, 2, 3] instead of stock.warehouse(1, 2, 3) is misleading, as it makes the variable look like it's a list instead of a recordset.

I wonder if that can be left as it was, without impacting the other niceties of this plugin.

@ntvsp
Copy link

ntvsp commented Oct 21, 2020

a ngọc làm plugin cho vscode rồi à

@yajo
Copy link
Author

yajo commented Oct 21, 2020

Where is it?

@cuongnmtm
Copy link
Contributor

cuongnmtm commented Oct 22, 2020

@yajo: tuanvuvd said that the author finally created the plugin for vscode. It's like a rhetorical question

@gdgellatly
Copy link

gdgellatly commented Oct 23, 2020

@cuongnmtm Yes we understand it works for VSCode, it was more why the repr() output disappears in VSCode. In the first screenshot you clearly see the repr() representation (without this plugin), in the screenshot in the README.md for this plugin you clearly see the repr() representation with the name, in the screenshot above, in VSCode there is no repr(). i.e. 2: {stock.warehouse: 3} [3] Chicago or similar

@cuongnmtm
Copy link
Contributor

@gdgellatly I tried to translate for Yajo

BTW, I like the way @trinhanhngoc adjusted repr() to show the record name. It's especially useful in case there are relationship fields inside

image

@cuongnmtm
Copy link
Contributor

@yajo @gdgellatly My pull request was merged. Could you please check the result? I think this issue is ok to close

@yajo
Copy link
Author

yajo commented Oct 26, 2020

Yes, pretty cool, thanks!

imagen

@yajo yajo closed this as completed Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants