Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to install numpy 1.17.0 with setup script #27

Closed
jedmijares opened this issue Mar 21, 2021 · 3 comments
Closed

Unable to install numpy 1.17.0 with setup script #27

jedmijares opened this issue Mar 21, 2021 · 3 comments

Comments

@jedmijares
Copy link

I wasn't able to install sumgram with pip on my machine, until I cloned it locally and changed the setup script to install the latest version of numpy instead of 1.17.0.

For reference, I'm on Ubuntu and using Python 3.8.5.

@anwala
Copy link
Member

anwala commented Mar 22, 2021

Hello @jedmijares,

Thanks for reporting this. We will investigate this.

Respectfully,

Alex

@shawnmjones
Copy link
Member

I just traced my Hypercane installation problems down to this. Remove the pinned version from setup.py (e.g., set numpy==1.17.1 to just numpy). From reviewing

sumgram/sumgram/sumgram.py

Lines 1178 to 1179 in 31434ea

all_col_sums_tf = np.sum(tf_matrix, axis=0)
all_non_zero = np.argwhere(tf_matrix != 0)
sumgram only needs the sum and argwhere functions. These shouldn't change between versions of numpy so there is no need to pin the version.

@anwala
Copy link
Member

anwala commented May 19, 2021

Hello @jedmijares and @shawnmjones. This issue has been resolved in sumgram v0.0.19. Thank you.

@anwala anwala closed this as completed May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants