Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: Added hook: check_model_has_tests_by_group #6

Merged
merged 13 commits into from
Feb 23, 2021

Conversation

jtalmi
Copy link
Contributor

@jtalmi jtalmi commented Feb 21, 2021

This PR adds a hook that checks if a model has a sufficient number of tests pulled out of a group of acceptable tests, e.g. this model has 1 of unique, unique_where, or unique_threshold.

@codecov-io
Copy link

codecov-io commented Feb 21, 2021

Codecov Report

Merging #6 (d339f07) into main (6a24a42) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main        #6   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           35        35           
  Lines         1485      1485           
  Branches       192       192           
=========================================
  Hits          1485      1485           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a24a42...d339f07. Read the comment docs.

Copy link
Contributor

@tomsej tomsej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🎉! I have run even mutation testing and all passes. Just delete unnecessary try and delete the unused import and we can merge that.

@jtalmi
Copy link
Contributor Author

jtalmi commented Feb 23, 2021

Looks great 🎉! I have run even mutation testing and all passes. Just delete unnecessary try and delete the unused import and we can merge that.

awesome. i just added a new commit to take care of requested changes.

@tomsej tomsej merged commit f58287f into dbt-checkpoint:main Feb 23, 2021
@tomsej
Copy link
Contributor

tomsej commented Feb 24, 2021

resolve #5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants