diff --git a/cardea-server/src/main/java/ca/on/oicr/gsi/cardea/server/service/CaseService.java b/cardea-server/src/main/java/ca/on/oicr/gsi/cardea/server/service/CaseService.java index accf722..b887048 100644 --- a/cardea-server/src/main/java/ca/on/oicr/gsi/cardea/server/service/CaseService.java +++ b/cardea-server/src/main/java/ca/on/oicr/gsi/cardea/server/service/CaseService.java @@ -174,7 +174,7 @@ private LocalDate getCompletedDate(Case kase) { return null; } for (CaseRelease release : deliverable.getReleases()) { - if (Boolean.TRUE.equals(release.getQcPassed())) { + if (!Boolean.TRUE.equals(release.getQcPassed())) { return null; } if (completedDate == null || completedDate.isBefore(release.getQcDate())) { diff --git a/changes/fix_shesmu_completedDate.md b/changes/fix_shesmu_completedDate.md new file mode 100644 index 0000000..708d4c9 --- /dev/null +++ b/changes/fix_shesmu_completedDate.md @@ -0,0 +1 @@ +Missing (null) `completedDate`s in `shesmu-cases` endpoint