Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please migrate to Python 3 #1

Open
aelmahmoudy opened this issue Sep 3, 2019 · 4 comments
Open

Please migrate to Python 3 #1

aelmahmoudy opened this issue Sep 3, 2019 · 4 comments

Comments

@aelmahmoudy
Copy link
Contributor

Python 2 end-of-life date is on 2020:
http://legacy.python.org/dev/peps/pep-0373/

please migrate okasha to Python3.

Note that ojuba-org/thawab#17, is blocked by this
issue.

I tried doing the migration, but I was blocked by the dependency on kid module
which doesn't seem to be migrated to python 3

@muayyad-alsadi
Copy link
Member

Are you sure that thawab uses kid module?
If so let's migrate to jinja

@aelmahmoudy
Copy link
Contributor Author

aelmahmoudy commented Sep 3, 2019 via email

@muayyad-alsadi
Copy link
Member

It's soft dependency and thawab does not use it

I've checked the code it uses bottle like templates

https://github.com/ojuba-org/thawab/blob/master/Thawab/webApp.py#L30

@aelmahmoudy
Copy link
Contributor Author

aelmahmoudy commented Sep 3, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants