-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subtitles render under mpv window on macOS #42
Comments
I installed xdotools per suggestion in this thread. After this, I tried once again and some really funny stuff happened were python opened up in the dock and I got two windows, separate from mpv, one rendering one word of the subtitle, and the other showing its meaning. Somehow I can't reproduce it again, but there's that. |
About About separate window - I've no idea why this happens. Maybe something to do with settings and your MacOS does not allow undecorated windows to show. Subtitles invisible but work as I understand? In that case it has something to do with compositor's settings. I'd look in that direction. |
Yes, they work, it's just the way they're rendered that doesn't allow me to make use of them. The issue is in fact, that the subtitles are rendered outside mpv. With a default mpv and script, they don't show up at all. If I make the two changes suggested here and here, they render functional, but outside the mpv window. The person who created that issue deleted his videos, so I can't compare to what his problem was, but if you look at his last window the subtitles render the same way, outside the window and on the desktop. Not sure why he didn't comment on it, seems like a big problem to me. I have never heard about a compositor before. I take it it's the engine that renders the windows on the OS. Do you have any idea on what I could change here? I've tried these but they make no difference. |
Now that subtitles are rendered properly, you may forget about compositor. It works properly. Subtitles are rendered independently of mpv's window. And thus they look good only in fullscreen mode, or with maximized window. |
Maybe you've started mpv with Try changing https://mpv.io/manual/stable/#options-ontop-level |
Hmmmm, I have not, it's the default config. I've tried changing to each of those options, but they don't make any difference. Damn, so close to having it work properly! If you don't have any more suggestions, I'll leave the issue open while I tweak things around and see if I manage to fix it. |
Search for |
It helped! Now they render on top of the window, but only if it's not fullscreen. Got any more of those lines to fix that? It's something there surely. For the sake of documentation, the complete line I'm using is |
Now once again try changing https://mpv.io/manual/stable/#options-ontop-level |
I tried all of them again and nothing. Maybe it's just how it is on macOS, wish other people could chime in and say how it goes for them. I'll settle with it as it is, you can close the issue if you'd like. Another thing, is that the subtitles are there no matter if I minimize or unfocus mpv. I tried |
There's a fork that seems to have been made for Mac. You might try it, or ask with the author about your issue. |
Just for the record it works the same on that fork. |
Then I'd say the problem is definitely somewhere in your settings. |
Maybe his fork isn't meant to address this? I'll try to ask him somehow, seems to have Issues disabled on it. @ewnd9 (maybe this will ping him) I'm not sure if it's even possible given how the script works. The way macOS handles fullscreen is that you only have that app fullscreen. When you fullscreen an app, there's an animation that moves the whole desktop into the left, and puts the fullscreened app into its own container. You can see it in these screenshots, the second is midst fullscreen animation: Because the script is considered its own app (Python on the dock), its window is moved into the left like all other processes. I've seen in very rare occasions, apps not being compliant with this type of fullscreen. You can find it because if you alt+cmd (alt+tab) away from it while in fullscreen, this animation isn't triggered. I know Kodi and Wine can do this, but I just tested with a Wine app, and it's the same thing. Just sharing my findings, I can live with this. Thanks a lot for the script, and I hope not to bother you too much with questions about it in the future. |
Fixed at last. Like I said, you have to get it done through that not-compliant fullscreen mode. IINA has it listed in its setting as "Use legacy full screen". Not sure what command it is on mpv.conf. |
How do you do this. Can you explain? Because I have the same problem. Are you using IINA instead of mpv if you do tell me please how? |
(sorry, quoting doesn't quite work for me) Yes, you have to use IINA instead of mpv. Just go to the main site, and then, on Preferences it's General > Use legacy full screen. |
Yeah, thanks I turn it on but have you any ideas how to make mpv scripts working on INNA? |
I don't use this script any longer, but I'll try to help. You have to go to .config > (to access .config, in Finder do Go > Go to Folder > ~/.config) here you create the folder "iina" and inside of this the folder "scripts". And you simply add the script there and it should work the same as it does on mpv (sometimes there are bugs though, you have to ask the iina developer on their github about it). |
Thank you I've fixed it. I used another method: simply added --no-native-fs to the 'mpv.conf' file, and now everything works. However, I have another issue: the script doesn't work without the terminal.
|
Trying to get this script to work. I'm on macOS and have manually installed these:
The ones I haven't marked, I didn't know how to install. In any case, a console instance kept informing me on what package was missing when I ran the script, until there were no errors. However, when I start the script still I just get no input beyond the subtitles disappearing and the prompt stating its started.
I tried multiple videos, .srt files, downloaded a clean mpv build, tried the deprecated tk version, but it makes no difference. The only thing that changes is using "python3" has no errors on the console, while "python" complains about:
The text was updated successfully, but these errors were encountered: