Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to csproj #35

Closed
Tyrrrz opened this issue Mar 22, 2019 · 3 comments
Closed

Migrate to csproj #35

Tyrrrz opened this issue Mar 22, 2019 · 3 comments

Comments

@Tyrrrz
Copy link
Contributor

Tyrrrz commented Mar 22, 2019

I'm using this library in an app that runs inside a docker container. Due to having been built with project.json format, this library requires an sdk image to run, which is significantly bigger than the runtime image. Switching to csproj should fix it.
@omar
Copy link
Owner

omar commented Mar 22, 2019

Hey @Tyrrrz, this will be solved in the 2.0 release (see v2.0.0-alpha). That version is built for .NET Standard and uses .csproj.

It seems to be pretty stable at the moment and I'm hoping to promote it to stable v2 after I finish reviewing comments on #24.

@Tyrrrz
Copy link
Contributor Author

Tyrrrz commented Mar 22, 2019

I'm not really interested in the metric changes in 2.0 and I would like this fix as soon as possible. I can make a PR with just this change, would you merge it?

@Tyrrrz
Copy link
Contributor Author

Tyrrrz commented Mar 22, 2019 •
edited
Loading

Also I would need to use this library in a project targeting net45 (outside of docker)

@Tyrrrz Tyrrrz mentioned this issue Mar 22, 2019
Merged
@omar omar closed this as completed in #36 Mar 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@omar @Tyrrrz