Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internationalization #40

Open
MorenoAlex opened this issue Feb 11, 2020 · 3 comments
Open

Internationalization #40

MorenoAlex opened this issue Feb 11, 2020 · 3 comments

Comments

@MorenoAlex
Copy link

Hi !
Amazing job on this library, it is so usefull.

Howerver I'm strugling will one thing : does the ToString function support units in other languages ?It does support english units (KB, MB, GB), but I'm having trouble with french.
In french a byte is called an "octet", so the units are writen like "Ko", "Mo", "Go"...
image

I can do something like
myByteSize.ToString("GB").Replace("GB", "Go")
but it's not very clean.

Am I missing something ?
If not, any chance to see an internationalization feature in the future ?
Thanks :)

@elgonzo
Copy link

elgonzo commented Mar 4, 2020

FYI: It's "ko" or "Kio", not "Ko" (https://fr.wikipedia.org/wiki/Octet) ;-)

@NJullienSweet
Copy link

Hello @omar, do you still maintain this repository?
If not, do you accept PRs? I see there is still one pending from May.
This i16n feature is rather important, considering French and Cyrillic languages (to name a few) do not use these units.

@omar
Copy link
Owner

omar commented Oct 14, 2023

@NJullienSweet, yes I accept PRs and have accepted multiple ones already. The one in May has my feedback on it which needs to be addressed by the author before I merge it in.

If you have time to implement i18n, happy to review and merge it in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants