Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitoring & alert for pending block submissions #1629

Closed
4 tasks
unnawut opened this issue Jul 8, 2020 · 1 comment · Fixed by #1649
Closed
4 tasks

Monitoring & alert for pending block submissions #1629

unnawut opened this issue Jul 8, 2020 · 1 comment · Fixed by #1649
Assignees
Labels
childchain enhancement New feature or request

Comments

@unnawut
Copy link
Contributor

unnawut commented Jul 8, 2020

Spinning off from #1617 (comment)

Do we alarm on all error log. If not let's make sure we add alarm on this, either via Datadog parsing the error message or do the direct alarm (?) from code?

Good idea! I think we can do with an app alarm when a block submission is pending for more than 2 blocks (since we're aiming for next-block inclusion, but I'll make number configurable in case of too many false panics). Then Datadog can consume this app alarm similar to :ethereum_stalled_sync and friends.

Since we're losing this visibility because this PR is suppressing the exception, I'll add :block_submission_stalled alarm to this PR.

Queue observability size. Hell yeah!

TODOs:

  • Add a monitor/metrics to track pending chch block submissions (pending_block_submissions)
  • There's a similar naming :pending_block_queue_length but this is watcher_info's mechanism. Come up with better metrics names to separate the two.
  • Raises an alarm when pending_block_submissions > 2
  • Clears the alarm when pending_block_submissions == 0 (we shouldn't be expecting the queue to be around for too long)
@unnawut
Copy link
Contributor Author

unnawut commented Jul 8, 2020

Closest metric we have right now is pending_transactions but it doesn't tell us the number of blocks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
childchain enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant