Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test signatures with typedDataSign #836

Open
pnowosie opened this issue Jul 11, 2019 · 2 comments
Open

test signatures with typedDataSign #836

pnowosie opened this issue Jul 11, 2019 · 2 comments
Labels
paused protocol Issue related to protocol and transaction format/crafting/signing.

Comments

@pnowosie
Copy link
Contributor

#825 introduced another way to sign a transaction. /transaction.create returns typed_data field which serves as a request to web3's eth.signTypedData. This function isn't fully implemented in all clients software yet. Currently the only tests on typed_data was manual tests with MetaMask.

📔 we're not ready to implement such test, however some results of our tries are worth to be noted,

Results with parity
Implementing #825 some effort was made to create such automated test with parity (parity 2.5.0-beta) which implements typedDataSign.

We learned from ☝️ experiments that parity requires optional parameter chainId as mandatory. Reported issue did not take result.

We made a changes that introduces chainId to our EIP712 domain, add prepare working test.
It might be useful, we situation would clarify and we get ready to implement this test.

@pnowosie pnowosie added question Questions and discussions paused and removed question Questions and discussions labels Jul 11, 2019
@InoMurko
Copy link
Contributor

is this still relevant @pnowosie ? if not pls close

@pdobacz
Copy link
Contributor

pdobacz commented Dec 16, 2019

such test (or something similar) would be a good check if our EIP712 structures are interpreted the same by an external signing facility (like geth, parity, Metamask etc.).

For now we only have some elixir-omg (our implementation) vs plasma-contracts (our implementation) tests

Not sure about priorities tho

@achiurizo achiurizo added the protocol Issue related to protocol and transaction format/crafting/signing. label Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paused protocol Issue related to protocol and transaction format/crafting/signing.
Projects
None yet
Development

No branches or pull requests

4 participants