Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use extensions for GPU packages #25

Closed
wants to merge 11 commits into from
Closed

Use extensions for GPU packages #25

wants to merge 11 commits into from

Conversation

omlins
Copy link
Owner

@omlins omlins commented Jan 9, 2024

This PR works except that the type aliases defined in the extensions cannot be made available to the user of the package (and it needs to be verified if the similar method defined has an effect).

To illustrate that the extensions work in general, the function some_function was added temporarily. It works as shown here:

julia> using CUDA


julia> using CellArrays
[ Info: Precompiling CellArrays [d35fcfd7-7af4-4c67-b1aa-d78070614af4]
[ Info: Precompiling CellArrays_CUDAExt [0f7d8a02-766a-50ac-8bd6-eb945167c0c4]

julia> some_function(CUDA.zeros(2))
2-element CuArray{Float32, 1, CUDA.Mem.DeviceBuffer}:
 1.0
 1.0

GPU unit tests pass (but only because the type aliases were defined directly in the test file):

Test Summary:     | Pass  Total   Time
test_CellArray.jl |  295    295  34.7s
     Testing CellArrays tests passed 

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1a4ed60) 63.56% compared to head (3deb122) 63.56%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #25   +/-   ##
=======================================
  Coverage   63.56%   63.56%           
=======================================
  Files           3        3           
  Lines         129      129           
=======================================
  Hits           82       82           
  Misses         47       47           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@omlins omlins changed the title Update CI Use extensions for GPU packages Jan 10, 2024
@omlins
Copy link
Owner Author

omlins commented Jan 29, 2024

Replaced by #26

@omlins omlins closed this Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants