Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn the user if a token transfer could exceed the limit on the token bridge #178

Open
akolotov opened this issue Jan 3, 2019 · 0 comments

Comments

@akolotov
Copy link
Collaborator

akolotov commented Jan 3, 2019

As part of omni/tokenbridge-contracts#117 the new functionality was introduced. It does not allow accepting the tokens relays if the amount of tokens is above the limits.

Test case for the erc20-to-native bridge mode:

  1. set the daily limit for the bridge in 50 ether.
  2. try to transfer 55 tokens from the Foreign chain to the Home chain by using the Bridge UI
    The results: the Bridge UI warns the end user that even if the transaction with transfer will not be reverted, relaying of tokens will not mint new coins on the Home chain since the transfer amount exceeds the limit.

Similar is applicable for erc20-to-erc20 bridge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant