Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check correctness of configuration parameters before the contracts deployment #185

Closed
akolotov opened this issue May 22, 2019 · 1 comment
Assignees

Comments

@akolotov
Copy link
Collaborator

At this moment a validation of the configuration parameters (deploy/src/loadEnv.js) allows to avoid very trivial mistakes in the configuration. But sometimes the bridge adopters meet the issues related with the contract internals (e.g. FOREIGN_MAX_AMOUNT_PER_TX cannot be equal to FOREIGN_DAILY_LIMIT in the native-to-erc20 mode or necessity to point out a real contract as the ERC20 token on the foreign side in the erc20-to-erc20 mode). In this case they get the initialization of the bridge contracts failed without detailed description of the problem and raise questions in the forum/gitter/slack etc.

It is necessary to review the code of the bridge contracts and implement the corresponding checks on the deployment script side as so the adopters receive meaningful information about the contracts deployment/initialization failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants