Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No check that the fee percentage is less than 100% #205

Closed
akolotov opened this issue Jun 26, 2019 · 1 comment
Closed

No check that the fee percentage is less than 100% #205

akolotov opened this issue Jun 26, 2019 · 1 comment
Labels
bug Something isn't working

Comments

@akolotov
Copy link
Collaborator

During the security audit it was found that operations to set the fee does not check that the fee is less than 1:

https://github.com/poanetwork/poa-bridge-contracts/blob/bbb97a63c900f03a902d0e82358abac3b294e4d9/contracts/upgradeable_contracts/BaseFeeManager.sol#L24-L27

https://github.com/poanetwork/poa-bridge-contracts/blob/bbb97a63c900f03a902d0e82358abac3b294e4d9/contracts/upgradeable_contracts/BaseFeeManager.sol#L33-L36
@patitonar patitonar mentioned this issue Jun 26, 2019
Merged
@akolotov akolotov added the bug Something isn't working label Jun 27, 2019
@akolotov
Copy link
Collaborator Author

Included in TokenBridge contracts 2.3.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@akolotov