Add V2 version of GotoDefinitionService #2168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The V1 GotoDefinitionService can only return one definition for a symbol. This is particularly annoying for partial types, which have multiple locations, and the location the service returns is pretty much never the one I want. The V2 service is very similar, but it uses V2 location models and returns a list of definitions, not a single one.
333fred
commented
May 30, 2021
|
@filipw @david-driscoll could you take a look? |
filipw
reviewed
May 30, 2021
filipw
reviewed
May 30, 2021
src/OmniSharp.Roslyn.CSharp/Services/Navigation/GoToDefinitionHelpers.cs
Outdated
Show resolved
Hide resolved
filipw
reviewed
May 30, 2021
filipw
reviewed
May 30, 2021
src/OmniSharp.Roslyn.CSharp/Services/Navigation/GoToDefinitionHelpers.cs
Show resolved
Hide resolved
|
@filipw addressed your feedback, thanks. |
333fred
commented
May 30, 2021
| @@ -260,7 +260,7 @@ private static async Task<CodeElement> TranslateAsync(this CodeElement element, | |||
| continue; | |||
| } | |||
|
|
|||
| builder.AddChild(childElement); | |||
| builder.AddChild(translatedElement); | |||
There was a problem hiding this comment.
This only ever worked because mutation.
This was referenced Aug 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The V1 GotoDefinitionService can only return one definition for a symbol. This is particularly annoying for partial types, which have multiple locations, and the location the service returns is pretty much never the one I want. The V2 service is very similar, but it uses V2 location models and returns a list of definitions, not a single one.