This repository has been archived by the owner on Sep 4, 2020. It is now read-only.
Fix buildXML() call for extension w/o update_url #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thom4parisot
pushed a commit
that referenced
this pull request
May 15, 2013
Fix buildXML() call for extension w/o update_url
|
Thank you for the fix. I've added a test to avoid reproducing the problem :-) |
|
Thank you for great plugin) Would you mind to update npm package? |
|
Yep it's in the pipe, just finishing publishing tests and README, it's online in a couple of minutes :-) Edit: it's live! and I gave you commit access too. |
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ChromeExtension.generateUpdateXML();must not be called if extension has noupdate_urlfield in manifest.