This repository has been archived by the owner on Sep 4, 2020. It is now read-only.
Remove "rm" dependency #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wouldn't it be better to use isaacs/rimraf instead of fs + wrench? |
|
Looks better to me, I will update the pull. |
|
Unfortunately rimraf doesn't handle "file/*" so I still have to use fs.mkdir to remake the directory. It is much cleaner with rimraf anyway though. |
| var path = require('path'); | ||
| var rimraf = require('rimraf'); | ||
| var fs = require('fs'); |
There was a problem hiding this comment.
fs is not used, remove it please.
|
Yes at some point I'd like to get rid of all system commands (even for zipping and encrypting the extension in the It might sound stupid but |
|
@ADotOut I've done a PR on your master as an alternate proposal. |
I didn't know grunt had all these utilities. Good find.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove dependency on rm. exec("rm") works on windows if you include git/bin in your PATH, but many users select the default value when installing git, which means they only get git.exe and none of the linux helper executables. A pure node solution is better anyway, I think :)
This will add a node dependency on the "wrench" library, which is what I used in the crx module.
I also added the system dependencies from the crx package, "openssl" and "ssh-keygen", into the README. If either of these are not installed the grunt task gives very cryptic errors.