-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Criteo self signed certificat #8
Criteo self signed certificat #8
Conversation
Good work 👍 Please, can you document this in the README? Bats tests runs simple bash instructions. For example, inside test/integration/self_certificate/bats/certificates_content_test.bats you can put the following: @test "the certificate has the correct issuer" {
openssl x509 -in /etc/ssl/certs/test.pem -noout -text \
| grep -F 'Issuer: C=FR, ST=Ile de Paris, L=Paris, O=Toto, OU=Titi, CN=ca.test.com/emailAddress=titi@test.com'
}
@test "the certificate has the correct subject" {
openssl x509 -in /etc/ssl/certs/test.pem -noout -text | grep -F 'Subject: [...]'
} Then test this with But don't worry too much about the bats tests, I can take care of them. |
I pushed tomorrow morning README + Bats test |
Thanks @jmauro, you are doing a great work! |
OK guys it done but added the option 'with-ca' for certificat, I think it is more explicit. Regards, |
It is perfect now. Thanks you @jmauro! I'm planning to release this in a couple of days, after some tests. |
Released in |
PL linked to "Adding a CA for self signed certificates" #5