-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IPC event pool function to strip/encode file descriptor from/to IPC event pool handle #205
Comments
@wdamon-intel : I think we can do this w/o problems. we have the ones for memory, we could add the ones for pools, following the same semantics and meaning. this should be easy to do for v1.8. |
Added zeEventPoolGetFileDescriptorFromIpcHandleExp zeEventPoolGetIpcHandleFromFileDescriptorExp To help users with the management of IPC event pool handles. Resolves: oneapi-src#205 Signed-off-by: Jaime Arteaga <jaime.a.arteaga.molina@intel.com>
@zzdanowicz please check #220 |
Moving out of v1.8 Release. Offline review highlighted a need for further discussion. |
We had a discussion on this and IPC should remain opaque, so any API's that expose internal handles / OS details shouldn't be added. |
So adding that two functions to strip wanted data out of opaque handles is justified. |
no , as it would make IPC not opaque. |
Retrieving data from opaque handler by dedicated function is making handler not opaque? We do not reveal memory layout that can change and sounds like contradiction to me - can you expand your thinking? |
to keep it opaque we should never return any handle via any APIs |
So retrieving via API call partial data from opaque handler is not an option? OK, but right now applications are stripping that data directly - this is much worse as driver can change memory layout of the opaque handler and applications would break. With these at least the driver allows for some control over applications. |
yes what is now is much worse, but this is due to the fact that IPC is not opaque. |
Equivalents of functions:
zeMemGetIpcHandleFromFileDescriptorExp
zeMemGetFileDescriptorFromIpcHandleExp
Function proposals:
zeEventPoolGetIpcHandleFromFileDescriptorExp(ze_context_handle_t hContext, uint64_t handle, ze_ipc_event_pool_handle_t *pIpcHandle)
ze_result_t zeEventPoolGetFileDescriptorFromIpcHandleExp(ze_context_handle_t hContext, ze_ipc_event_pool_handle_t ipcHandle, uint64_t *pHandle)
The text was updated successfully, but these errors were encountered: