Additional test scenario required here

[SergeyKopienko]

oneDPL/test/general/header_inclusion_order_algorithm_0.pass.cpp

Line 16 in e25afef

#include "support/test_config.h"

Additional test scenario required here:

• when #include "support/test_config.h" is the first include;
• when #include "support/test_config.h" is the last include;
• for all header_inclusion_*.pass.cpp files.

[SergeyKopienko]

Probably after merge the PR #1250 this issue isn't actual.
@danhoeflinger, @kboyarinov how do you thinks?

[kboyarinov]

I am not aware (or not remember:)) on what initially caused this issue and why the additional testing was required. If you remind me, I would be able to advice if the issue was fixed by my PR or not.

[danhoeflinger]

This issue was added when we added #include <version> (or its predecessor) in to test_config.h (which was merged after #1250) from this comment: #1548 (review).

Currently, all of these header inclusion tests include test/support/test_config.h first, which in turn includes <version> or <ciso646>. The intention here was to have a test of the alternative to check for include order issues in combination with STL.

I'm not sure if these tests would show the issue #1250 fixes, but it being fixed doesn't remove the want for a test. #1584 extends the fixes for #1250 further, so there are probably multiple cases here that could deserve testing for regression if we don't have them already.