Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with make_zip_view with certain input types #1805

Open
danhoeflinger opened this issue Aug 29, 2024 · 0 comments
Open

Issue with make_zip_view with certain input types #1805

danhoeflinger opened this issue Aug 29, 2024 · 0 comments

Comments

@danhoeflinger
Copy link
Contributor

I don't like that this change is required, but it mirrors how it is currently handled in the ranges implementation.


Its needed here because we are unifying the ranges API and main API handling of __parallel_copy_if to enable the performance improvements to be felt in both cases, and also to remove redundant code.

This is to avoid an issue with making a zip_view from a non const lvalue reference to a zip view. There may be changes we can make to our internal tuple class to resolve this, but I think that lies outside the scope of this PR.

Originally posted by @danhoeflinger in #1763 (comment)

An issue arises in reduce_by_key_ranges_sycl.pass when using make_zip_view and forwarding instead of using zip_view constructor here with a copy of the range. This seems wrong, and may imply changes with zip_view or our internal tuple.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant