Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for non-ascii fields in settings. #164

Merged
merged 1 commit into from
Sep 23, 2016

Conversation

mtyaka
Copy link
Contributor

@mtyaka mtyaka commented Sep 22, 2016

This patch adds support for using unicode strings that contain non-ascii characters in settings.

Trying to use non-ascii characters for contact person's given name for example, would fail with unicode encode errors in various places.

The most common settings that may contain non-ascii characters are:

{
  ...
  "contactPerson": {
    "technical": {
      "givenName": "uTéçhnïçäl Nämé",
      ...
    },
    "support": {
      "givenName": u"Süppört Nämé",
      ...
    }
  },

  "organization": {
    "en-US": {
      "displayName": u"Sérvïçé prövïdér",
      ...
    }
  },
  ...
}

@pitbulk
Copy link
Contributor

pitbulk commented Sep 22, 2016

Thanks for contribute.

Can you add custom test settings and specific unit test instead of modify the settings and the tests that we had?

@mtyaka
Copy link
Contributor Author

mtyaka commented Sep 22, 2016

Thanks for the quick response @pitbulk!

Sure, I will do that tomorrow.

@mtyaka
Copy link
Contributor Author

mtyaka commented Sep 23, 2016

@pitbulk I made the requested changes and rebased.

@pitbulk pitbulk merged commit aef5af9 into SAML-Toolkits:master Sep 23, 2016
@bradenmacdonald bradenmacdonald deleted the mtyaka/non-ascii-support branch October 26, 2016 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants