Overridability enhancements #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pitbulk Mind reviewing this? :) |
|
Sorry for the long delay. I was trying to find another possible solution with fewer changes in the code. |
|
Thanks @pitbulk 😄 Happy new year! 🎆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #208 (comment), this PR makes it possible to override the request ID for an authentication request.
To make that easier in turn, this PR also "indirects" some of those classes by storing them as class attributes on the classes that use them, and similarly some methods that used to be staticmethods and called out to other staticmethods on the same class are now classmethods, to allow for overriding them in subclasses.