Replace double-underscored names with single underscores #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will avoid Python's class-name-prefix mangling of attributes and methods while still retaining the signal that they're meant for private use of the library. This makes it easier to e.g. subclass classes should one need to, and to access data from outside (while being mindful of the fact that you're accessing notionally private data). Only one change to a test was required (and that test was indeed accessing a private field from outside...).
|
WIll consider this change for a future release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will avoid Python's class-name-prefix mangling of attributes and methods while still retaining the signal that they're meant for private use of the library.
This makes it easier to e.g. subclass classes should one need to (e.g. as I needed in #212), and to access data from outside (while being mindful of the fact that you're accessing notionally private data).
Only one change to a test was required (and that test was indeed accessing a private field from outside and had to jump through hoops 😄 ).