Deprecate server_port from request data dictionary #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akx
force-pushed
the
remove-server-port-from-request-data
branch
from
96d3b79
to
3a208fb
Compare
`server_port` is unnecessary, since the HTTP Host header sent by the client already includes any non-standard port. In addition, when the Python application server is sitting behind a reverse proxy/TLS terminator, SERVER_PORT is likely to be wrong anyway (since it would be the server port of the non-reverse-proxied server). See SAML-Toolkits#273 (comment)
akx
force-pushed
the
remove-server-port-from-request-data
branch
from
3a208fb
to
f435584
Compare
|
@pitbulk Review concerns addressed. I don't know where the review comments went – maybe you had made them as comments on the commit instead of a PR review? |
pitbulk
approved these changes
Jul 26, 2021
shadowbrush
pushed a commit
to shadowbrush/social-core
that referenced
this pull request
Mar 2, 2022
server_port has been deprecated by python3-saml, see: SAML-Toolkits/python3-saml#276 If the server application is running behind a load balancer or a reverse proxy the request port might not match the SAML configuration. This will resolve issue python-social-auth#609 - python-social-auth#609
9 tasks
nijel
pushed a commit
to python-social-auth/social-core
that referenced
this pull request
Mar 3, 2022
server_port has been deprecated by python3-saml, see: SAML-Toolkits/python3-saml#276 If the server application is running behind a load balancer or a reverse proxy the request port might not match the SAML configuration. This will resolve issue #609 - #609
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
server_portis unnecessary, since the HTTP Host header sent by the client already includes any non-standard port. (This is stuffed intohttp_host.)In addition, when the Python application server is sitting behind a reverse proxy/TLS terminator, SERVER_PORT is likely to be wrong anyway (since it would be the server port of the non-reverse-proxied server).
See #273 (comment)