Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require yanked version of lxml #297

Merged
merged 3 commits into from
Feb 16, 2022

Conversation

akx
Copy link
Collaborator

@akx akx commented Jan 31, 2022

Version 4.7.0 of lxml was yanked from pypi because it was missing some required data.

Version 4.7.1 replaces it; changing the specifier from == to ~= allows any 4.7.x series lxml.

EDIT: I just saw #292 / a55cc9a ... has this been reported upstream to lxml?

@pitbulk
Copy link
Contributor

pitbulk commented Feb 8, 2022

In that case i prefer
lxml<4.7.1

@bzvestey a new python3-saml release should be done including the 2 PRs recently approved and the change with lxml<4.7.1

@akx I believe the bug was introduced by
lxml/lxml#332

@bzvestey
Copy link
Contributor

bzvestey commented Feb 9, 2022

@eriktalvi FYI

@pitbulk
Copy link
Contributor

pitbulk commented Feb 14, 2022

@eriktalvi any ETA for solving this? It is impacting some customers.

@eriktalvi
Copy link

eriktalvi commented Feb 16, 2022

Going with @pitbulk's suggestion. There was an issue with 4.7.1 that I don't want to reintroduce without fixing.

@eriktalvi eriktalvi marked this pull request as ready for review February 16, 2022 00:31
@eriktalvi eriktalvi merged commit f313715 into SAML-Toolkits:master Feb 16, 2022
@bzvestey
Copy link
Contributor

bzvestey commented Feb 18, 2022

This have been release as part of version 1.14.0

@tkdchen
Copy link

tkdchen commented Feb 27, 2022

@pitbulk Hello, why lxml/lxml#332 introduced the bug? IIUC, the final result of this pr is just to add a few tests. Anything I missed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants