Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for issue where if there were multiple signing certs and no encry… #65

Merged
merged 3 commits into from
Sep 14, 2017
Merged

fix for issue where if there were multiple signing certs and no encry… #65

merged 3 commits into from
Sep 14, 2017

Conversation

bmorgan21
Copy link
Contributor

…ption certs, only the first signing cert is returned

@bmorgan21
fix for issue where if there were multiple signing certs and no encry…
362e2cb 
…ption certs, only the first signing cert is returned
@pitbulk
Copy link
Contributor

pitbulk commented Sep 7, 2017

Can you provide test so we assure we don't break in the future?

@bmorgan21
Copy link
Contributor Author

yes, just figuring out the environment. Once the tests pass, I will update the tests.

@coveralls
Copy link

coveralls commented Sep 7, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.9%) to 95.615% when pulling 49574c3 on bmorgan21:master into 16cd67c on onelogin:master.

@coveralls
Copy link

coveralls commented Sep 7, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.9%) to 95.615% when pulling 3d35b5c on bmorgan21:master into 16cd67c on onelogin:master.

@bmorgan21
Copy link
Contributor Author

@pitbulk this PR should be ready for you to take a look!

@bmorgan21
Copy link
Contributor Author

Anything else needed here to get this merged and to make a patch release?

@bmorgan21 bmorgan21 mentioned this pull request Sep 11, 2017
Closed
@pitbulk pitbulk merged commit 141798f into SAML-Toolkits:master Sep 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bmorgan21 @pitbulk @coveralls