Preserve xmlns:xs namespace when signing and serializing responses #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pitbulk For review please. |
|
Any word on this PR? We're having to work around it right now, would be nice to have this merged. |
|
Same here. Anything we can do to get this PR passed and merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for: #76
This PR overrides the
OneLogin_Saml2_XMLstatic methodcleanup_namspaces, which is directly invokingetree.cleanup_namespaces. I added a whitelist of namespaces that should not be cleaned from an element before serialization into XML. This preserves thexmlns:xsnamespace that's specifically needed to validate the schema of a SAML Response's attributes.I also added some additional namespace prefix constants (now grouped with the other namespace constants) in
OneLogin_Saml2_Constants.