Support AttributeConsumingServiceIndex in AuthnRequest #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 28, 2014
|
This seems ok to me, any thoughts @cgthornt ? |
|
Yeah looks good to me! |
|
However, might it be a good idea to document this in the README file? |
|
@sebastienluquet any chance you could update readme.md with this change? |
|
Done |
|
Should I submit another pull request or could you merge this one with my update on readme (I push --force) ? |
|
Could this patch be merged. I'm leaving my current job and I would prefer giving posterity a Gemfile using upstream master than some nasty fork |
Lordnibbler
added a commit
that referenced
this pull request
Jun 25, 2014
Support AttributeConsumingServiceIndex in AuthnRequest
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicate #95 but with rebased code