-
-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relax nokogiri gem requirements #194
Conversation
61653c4
to
697c62a
Compare
@Lordnibbler, good change for the version. That helps me in my case where the app is sitting at |
@elskwid yes, sorry about this -- it was an overlooked change when we switched to Minitest. |
# 1.8.7 | ||
s.add_runtime_dependency('nokogiri', '~> 1.5.10') | ||
else | ||
s.add_runtime_dependency('nokogiri', '~> 1.6') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be ~> 1.6.0
? Without using the patch-level identifier, this runs the risk of v1.7+ breaking something in the future. Otherwise you could remove the conditional and just use ~> 1.5
and that should satisfy everything Ruby 1.8+.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@phlipper I will make the change to ~> 1.6.0
, but unfortunately setting it to ~> 1.5
will still cause Ruby 1.8 to try to install Nokogiri 1.6.x, despite it not being compatible :(
👍 |
8171a14
to
697c62a
Compare
- dont use weird array syntax for dependency definitions
697c62a
to
2738132
Compare
Relax nokogiri gem requirements
Status
READY
Description
Adjust
nokogiri
gem requirement:Todos