Allow requirement of single files #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures dependencies are properly required in each file
Closed
|
👍 |
|
@luisvm , @Lordnibbler what do you think? |
|
👍 |
2 similar comments
|
👍 |
|
👍 |
Lordnibbler
added a commit
that referenced
this pull request
Mar 18, 2015
Allow requirement of single files
|
thank you @rafaelgonzalez ! |
|
Cheers everyone |
|
The file onelogin.rb is unnecessary since we don't use any I noticed that in ruby-saml-example we never used with the gem installed, it imports the lib/ruby-saml.rb so the library is available. After read the REQUIRING CODE section of rubygem I saw that is common to set in the lib path a file with the name of the library, so I will replace lib/onelogin.rb by lib/ruby-saml.rb .That will maintain ruby-saml-example compatibility. @Lordnibbler, are you agree? |
phlipper
added a commit
to 01Click/ruby-saml
that referenced
this pull request
Mar 24, 2015
* SAML-Toolkits#205 introduced a regression when the entry point file was renamed: `lib/ruby-saml.rb → lib/onelogin/ruby-saml.rb`. this is causing problems with `bundler`, and also when integrating with other libraries such as `omniauth-saml`.
phlipper
added a commit
to 01Click/ruby-saml
that referenced
this pull request
Mar 24, 2015
* SAML-Toolkits#205 introduced a regression when the entry point file was renamed: `lib/ruby-saml.rb → lib/onelogin/ruby-saml.rb`. this is causing problems with `bundler`, and also when integrating with other libraries such as `omniauth-saml`.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to reflect the advertised behaviour in the README.
You can manually test requirements of each file in
irb(exitingirbbetween each) with:require_relative 'lib/onelogin/ruby-saml/authrequest'require_relative 'lib/onelogin/ruby-saml/logoutrequest'require_relative 'lib/onelogin/ruby-saml/logoutresponse'require_relative 'lib/onelogin/ruby-saml/settings'require_relative 'lib/onelogin/ruby-saml/slo_logoutrequest'require_relative 'lib/onelogin/ruby-saml/slo_logoutresponse'