Add :skip_audience option #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pitbulk Can I get your review/approval on this please? |
pitbulk
reviewed
Sep 30, 2020
|
Can you update the README (Like 294) to mention this skip option? |
swordfish444
commented
Sep 30, 2020
|
@pitbulk ready for re-review. Not sure if you're setup to monitor requests for re-review, but I triggered that as well. APologies for multiple notifications in the event you are! If there are no further questions/feedback, can we get this approved/merged and put an ETA on when the next release can be pushed out? |
pitbulk
approved these changes
Sep 30, 2020
|
I'm releasing java-saml toolkit and ruby-saml will be the next, I hope to release it in 1-2 weeks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds an option to the SAML Response class, to skip the assertions during
#validate_audience.Why this matters?
Some Service providers want to relax validation, and have this control via configuration. This was first surfaced in #515 and @pitbulk requested opening a PR to introduce it. Here's the PR =)