From f3922f8f71b85ff2f7389ef5c5fc8716a039a59b Mon Sep 17 00:00:00 2001 From: rushtehrani Date: Tue, 29 Dec 2020 18:19:25 -0800 Subject: [PATCH] fix reserved word validation issue --- cmd/build_test.go | 2 +- manifest/manifest.go | 1 + util/status.go | 1 - 3 files changed, 2 insertions(+), 2 deletions(-) diff --git a/cmd/build_test.go b/cmd/build_test.go index 5b1d0d9..d2924c7 100644 --- a/cmd/build_test.go +++ b/cmd/build_test.go @@ -46,4 +46,4 @@ func Test_generateApplicationNodePoolOptions(t *testing.T) { assert.Nil(t, err) assert.Equal(t, nodePoolOptionsExpected, nodePoolOptionsActual) -} \ No newline at end of file +} diff --git a/manifest/manifest.go b/manifest/manifest.go index 62c6dec..39e6322 100644 --- a/manifest/manifest.go +++ b/manifest/manifest.go @@ -125,6 +125,7 @@ func Validate(manifest *util.DynamicYaml) error { "knative-serving": true, "kube-public": true, "kube-system": true, + "default": true, } defaultNamespace := manifest.GetValue("application.defaultNamespace") diff --git a/util/status.go b/util/status.go index e9db6b9..279a026 100644 --- a/util/status.go +++ b/util/status.go @@ -12,7 +12,6 @@ func DeploymentStatus(yamlFile *DynamicYaml) (ready bool, err error) { namespacesToCheck["application-system"] = true namespacesToCheck["onepanel"] = true namespacesToCheck["istio-system"] = true - namespacesToCheck["default"] = true if yamlFile.HasKey("certManager") { namespacesToCheck["cert-manager"] = true