Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Big pile of suggested tweaks, mostly for site-independence #1

Open
1 of 5 tasks
lewiscollard opened this issue Nov 16, 2016 · 0 comments
Open
1 of 5 tasks

Big pile of suggested tweaks, mostly for site-independence #1

lewiscollard opened this issue Nov 16, 2016 · 0 comments

Comments

@lewiscollard
Copy link

lewiscollard commented Nov 16, 2016

  • Content type URLconf is specified as urlconf = "lcfi.apps.events.urls" - should use {{ project_name }}.apps.events.urls
  • hero_super_title is specified but many sites will not use supertitles. Maybe hero_title could be omitted as well?
  • end_date can be made optional, just assume it's a single-day event if only one date is specified (make sure emptiness is checked in the date property)
  • get_summary checks for a non-existent summary field (perhaps adding a summary field would be a good idea)
  • Add an optional location field? I can't think of any recent projects that would not benefit from it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant