Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot set kf.indicatorType in swift 3 #469

Closed
AndrewBarba opened this issue Oct 5, 2016 · 3 comments
Closed

Cannot set kf.indicatorType in swift 3 #469

AndrewBarba opened this issue Oct 5, 2016 · 3 comments

Comments

@AndrewBarba
Copy link

AndrewBarba commented Oct 5, 2016

See below:

screen shot 2016-10-05 at 12 43 14 pm

It makes sense, since kf is a struct, setting a property would have to change kf on the image view but I believe you only have a getter for that.

Using kf_indicatorType = .activity continues to work but shows the deprecation warning

@AndrewBarba
Copy link
Author

I should have been more clear, this does not compile:

let imageView = UIImageView()
imageView.kf.indicatorType = .activity

But this does:

var imageView = UIImageView()
imageView.kf.indicatorType = .activity

The screenshot I posted is my own extension on UIImageView which I guess is the same thing as the let case

@onevcat
Copy link
Owner

onevcat commented Oct 6, 2016

:( You are right. I will take a look to see what we could do for it.

@onevcat
Copy link
Owner

onevcat commented Oct 6, 2016

Fixed in #470

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants