Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New revertibleRandom function (FLIP 120) #2869

Closed
1 of 2 tasks
tarakby opened this issue Oct 13, 2023 · 2 comments · Fixed by #2896
Closed
1 of 2 tasks

New revertibleRandom function (FLIP 120) #2869

tarakby opened this issue Oct 13, 2023 · 2 comments · Fixed by #2896
Assignees
@tarakby
Labels
Feature

Comments

@tarakby
Copy link
Contributor

tarakby commented Oct 13, 2023 •
edited
Loading

Issue to be solved

The reasons are discussed in onflow/flips#120.

Suggested Solution

  • add a new function revertibleRandom with the same interface as the existing unsafeRandom.
  • update the doc

Note that fun unsafeRandom(): UInt64 should not be removed to avoid immediate breaking change.
The remaining FLIP120 implementation tasks are described in #2712
@tarakby tarakby self-assigned this Oct 13, 2023
@tarakby tarakby removed the Feedback label Oct 13, 2023
@tarakby tarakby mentioned this issue Oct 13, 2023
Closed
4 tasks
@tarakby
Copy link
Contributor Author

tarakby commented Oct 13, 2023

FYI, I'll make a PR to implement this issue.

@tarakby tarakby mentioned this issue Oct 24, 2023
Merged
6 tasks
@tarakby
Copy link
Contributor Author

tarakby commented Oct 27, 2023

This PR hasn't been merged yet onflow/docs#423 and it's part of the issue definition. Though I don't know if we can merge it while the function isn't on Mainnet yet.

@turbolent turbolent mentioned this issue Oct 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tarakby tarakby

Labels
Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add new revertibleRandom function onflow/cadence
1 participant
@tarakby