[Access] Getting account from local storage returns not found error

[peterargue]

When getting an account from local storage on an Access node, a NotFound error is returned for accounts with no contracts deployed. e.g.

rpc error: code = NotFound desc = account with address 232f1bc00d90a1c2 not found: failed to get account (232f1bc00d90a1c2) at block (18644be942ea58275cfc9523bcf359816dd72559c0c3c793c1e930f68689980e): cannot get account, this error usually happens if the reference block for this query is not set to a recent block: cannot get deployed contract names: failed to read 232f1bc00d90a1c2/#636f6e74726163745f6e616d6573: [Failure Code: 2002] ledger returns unsuccessful: get register failed: key not found

This points to an error at this line:

flow-go/fvm/environment/accounts.go

Lines 610 to 613 in 0435707

	encContractNames, err := a.GetValue(flow.ContractNamesRegisterID(address))
	if err != nil {
	return nil, fmt.Errorf("cannot get deployed contract names: %w", err)
	}

[janezpodhostnik]

This is a ledger failure... something in the ledger returned an error.
for accounts with no contracts, the ledger should return an empty payload (because nothing was saved to the contracts register yet) but the ledger returns an error instead.

Are we returning an error when a key is not found? That is not the current behaviour of the ledger...

[sideninja]

Yes we are, will change that behavior after I can confirm it's not expected somewhere else.
I guess with that PR I should also update the comment defining this behaviour on ledger?

flow-go/ledger/ledger.go

Line 34 in 6af8b17

// Get returns values for the given slice of keys at specific state

or you think that's no the right place?

[sideninja]

Actually it's already commented here

flow-go/fvm/storage/snapshot/storage_snapshot.go

Line 11 in 3245841

// for the same id).