Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EVM] Events emitted from EVM are not encoded as other FVM events #5079

Closed
sideninja opened this issue Nov 29, 2023 · 0 comments · Fixed by #5090
Closed

[EVM] Events emitted from EVM are not encoded as other FVM events #5079

sideninja opened this issue Nov 29, 2023 · 0 comments · Fixed by #5090
Assignees
Milestone

Comments

@sideninja
Copy link
Contributor

sideninja commented Nov 29, 2023

The events we emit from EVM are not CCF/CBOR encoded which causes issues in the current implementation of APIs and clients.

I believe we should encode all EVM events in the same way as other events and keep the CCF encoding, this way all the existing clients and APIs will work, otherwise we have to handle this exception in all places, and to those who don't care about EVM side of things they will potentially have issues just tracking the events on Flow which doesn't make sense. At the same time I think interacting with Flow we should expect Flow/Cadence types. EVM responses should be decoded by the specific EVM clients from the native Flow types.

@sideninja sideninja self-assigned this Nov 29, 2023
@sideninja sideninja changed the title [EVM] Events emitted from EVM are not cbor encoded [EVM] Events emitted from EVM are not encoded as other FVM events Nov 29, 2023
@franklywatson franklywatson added this to the Emulator Beta release milestone Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants