Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine access control #5

Open
sisyphusSmiling opened this issue Mar 3, 2023 · 0 comments
Open

Refine access control #5

sisyphusSmiling opened this issue Mar 3, 2023 · 0 comments
Assignees
@sisyphusSmiling
Labels
enhancement New feature or request SC-Eng Issues that we want to see surfaced in SC-Eng ZH Board

Comments

@sisyphusSmiling
Copy link
Collaborator

Issue To Be Solved

We'll want to scope out any potential to further encapsulate Capabilties behind getters/setters.

Suggest A Solution

For starters, we'll want to encapsulate ChildAccountManager.childAccounts behind access(self). Given how quickly we were moving to get this on testnet, there may be additional opportunities to encapsulate contained values in contract resources.
@sisyphusSmiling sisyphusSmiling added the enhancement New feature or request label Mar 3, 2023
@sisyphusSmiling sisyphusSmiling self-assigned this Mar 3, 2023
This was referenced Mar 15, 2023
Merged
Merged
@sisyphusSmiling sisyphusSmiling added the SC-Eng Issues that we want to see surfaced in SC-Eng ZH Board label Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sisyphusSmiling sisyphusSmiling

Labels
enhancement New feature or request SC-Eng Issues that we want to see surfaced in SC-Eng ZH Board
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sisyphusSmiling