Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find a replacement for inefficient Prometheus packet counters #33

Open
onitake opened this issue Jul 8, 2021 · 0 comments
Open

Find a replacement for inefficient Prometheus packet counters #33

onitake opened this issue Jul 8, 2021 · 0 comments
Labels

Comments

@onitake
Copy link
Owner

onitake commented Jul 8, 2021

This is a follow-up to #32 .

The Prometheus packet counters can cause performance issues when they are called very often.

Find a replacement for them that doesn't impact stream quality.

Ideas:

  • Move the counters to metrics/stats.go and update them only periodically
  • Consult the github.com/prometheus/client_golang changelog to find out if more efficient version or usage pattern is available
@onitake onitake added the bug label Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant